Mesa (master): intel: no-op the intel_finish_render_texture() function
Brian Paul
brianp at kemper.freedesktop.org
Fri Feb 27 01:51:05 UTC 2009
Module: Mesa
Branch: master
Commit: 4f8ed56d168e9175e76bc42d8b924c7bcaa59dea
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f8ed56d168e9175e76bc42d8b924c7bcaa59dea
Author: Brian Paul <brianp at vmware.com>
Date: Thu Feb 26 18:42:00 2009 -0700
intel: no-op the intel_finish_render_texture() function
It doesn't have to do anything. See comments for more details.
---
src/mesa/drivers/dri/intel/intel_fbo.c | 23 ++++++++++-------------
1 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c
index 5307537..787c290 100644
--- a/src/mesa/drivers/dri/intel/intel_fbo.c
+++ b/src/mesa/drivers/dri/intel/intel_fbo.c
@@ -612,19 +612,16 @@ static void
intel_finish_render_texture(GLcontext * ctx,
struct gl_renderbuffer_attachment *att)
{
- struct intel_renderbuffer *irb = intel_renderbuffer(att->Renderbuffer);
-
- DBG("End render texture (tid %x) tex %u\n", _glthread_GetID(), att->Texture->Name);
-
- if (irb) {
- /* just release the region */
- intel_region_release(&irb->region);
- }
- else if (att->Renderbuffer) {
- /* software fallback */
- _mesa_finish_render_texture(ctx, att);
- /* XXX FBO: Need to unmap the buffer (or in intelSpanRenderStart???) */
- }
+ /* no-op
+ * Previously we released the renderbuffer's intel_region but
+ * that's not necessary and actually caused problems when trying
+ * to do a glRead/CopyPixels from the renderbuffer later.
+ * The region will be released later if the texture is replaced
+ * or the renderbuffer deleted.
+ *
+ * The intention of this driver hook is more of a "done rendering
+ * to texture, please re-twiddle/etc if necessary".
+ */
}
More information about the mesa-commit
mailing list