Mesa (mesa_7_5_branch): i915: Only use the new 945 cube layout for compressed textures.

Eric Anholt anholt at kemper.freedesktop.org
Wed Jun 17 19:06:14 UTC 2009


Module: Mesa
Branch: mesa_7_5_branch
Commit: fbd554d07456cf393a20cb86d1c0e81c416843aa
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbd554d07456cf393a20cb86d1c0e81c416843aa

Author: Eric Anholt <eric at anholt.net>
Date:   Fri May 15 11:41:42 2009 -0700

i915: Only use the new 945 cube layout for compressed textures.

The docs actually explain this, but not in a terribly clear manner.
This nearly fixes the piglit cubemap testcase, except that something's
going wrong with the nearest filtering at 2x2 sizes in the testcase.
Looks good by visual inspection, though.

Bug #21692
(cherry picked from commit 5c5a46884899ea25cdf25545d6ab3d9a74eafa3a)

---

 src/mesa/drivers/dri/i915/i915_tex_layout.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i915/i915_tex_layout.c b/src/mesa/drivers/dri/i915/i915_tex_layout.c
index d44a2f4..7cc1c09 100644
--- a/src/mesa/drivers/dri/i915/i915_tex_layout.c
+++ b/src/mesa/drivers/dri/i915/i915_tex_layout.c
@@ -454,7 +454,10 @@ i945_miptree_layout(struct intel_context *intel, struct intel_mipmap_tree * mt)
 {
    switch (mt->target) {
    case GL_TEXTURE_CUBE_MAP:
-      i945_miptree_layout_cube(intel, mt);
+      if (mt->compressed)
+	 i945_miptree_layout_cube(intel, mt);
+      else
+	 i915_miptree_layout_cube(intel, mt);
       break;
    case GL_TEXTURE_3D:
       i945_miptree_layout_3d(intel, mt);




More information about the mesa-commit mailing list