Mesa (mesa_7_5_branch): scons: Don' t raise an exception when DXSDK is not found.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Mon Jun 29 11:56:56 UTC 2009


Module: Mesa
Branch: mesa_7_5_branch
Commit: 9a5ee124347d3f75be2e957142143338dd96abe3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9a5ee124347d3f75be2e957142143338dd96abe3

Author: José Fonseca <jfonseca at vmware.com>
Date:   Mon Jun 29 12:56:47 2009 +0100

scons: Don't raise an exception when DXSDK is not found.

Unfortunately scons does not check if a tool exists before it invokes
its generate function.

---

 scons/dxsdk.py |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/scons/dxsdk.py b/scons/dxsdk.py
index a369e1d..de090e4 100644
--- a/scons/dxsdk.py
+++ b/scons/dxsdk.py
@@ -40,10 +40,11 @@ def get_dxsdk_root(env):
     except KeyError:
         return None
 
-def get_dxsdk_paths(env):
+def generate(env):
     dxsdk_root = get_dxsdk_root(env)
     if dxsdk_root is None:
-        raise SCons.Errors.InternalError, "DirectX SDK not found"
+        # DirectX SDK not found
+        return
 
     if env['machine'] in ('generic', 'x86'):
         target_cpu = 'x86'
@@ -57,9 +58,6 @@ def get_dxsdk_paths(env):
     env.Prepend(CPPPATH = [os.path.join(dxsdk_root, 'Include')])
     env.Prepend(LIBPATH = [os.path.join(dxsdk_root, 'Lib', target_cpu)])
 
-def generate(env):
-    get_dxsdk_paths(env)
-
 def exists(env):
     return get_dxsdk_root(env) is not None
 




More information about the mesa-commit mailing list