Mesa (master): st: use pointer_to_offset() cast wrapper to convert pointers to uint

Brian Paul brianp at kemper.freedesktop.org
Mon Mar 9 15:44:25 UTC 2009


Module: Mesa
Branch: master
Commit: 44af5a953f4189978f698b6a26b5f7b1c6298929
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=44af5a953f4189978f698b6a26b5f7b1c6298929

Author: Brian Paul <brianp at vmware.com>
Date:   Mon Mar  9 09:33:46 2009 -0600

st: use pointer_to_offset() cast wrapper to convert pointers to uint

Silences warnings with 64-bit builds.  See comments for details.

---

 src/mesa/state_tracker/st_draw.c          |    6 +++---
 src/mesa/state_tracker/st_draw.h          |   15 +++++++++++++++
 src/mesa/state_tracker/st_draw_feedback.c |    2 +-
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c
index be1d9a8..772280d 100644
--- a/src/mesa/state_tracker/st_draw.c
+++ b/src/mesa/state_tracker/st_draw.c
@@ -379,7 +379,7 @@ setup_interleaved_attribs(GLcontext *ctx,
          else {
             vbuffer->buffer = NULL;
             pipe_buffer_reference(&vbuffer->buffer, stobj->buffer);
-            vbuffer->buffer_offset = (unsigned) low;
+            vbuffer->buffer_offset = pointer_to_offset(low);
          }
          vbuffer->stride = stride; /* in bytes */
          vbuffer->max_index = max_index;
@@ -434,7 +434,7 @@ setup_non_interleaved_attribs(GLcontext *ctx,
 
          vbuffer[attr].buffer = NULL;
          pipe_buffer_reference(&vbuffer[attr].buffer, stobj->buffer);
-         vbuffer[attr].buffer_offset = (unsigned) arrays[mesaAttr]->Ptr;
+         vbuffer[attr].buffer_offset = pointer_to_offset(arrays[mesaAttr]->Ptr);
          velements[attr].src_offset = 0;
       }
       else {
@@ -618,7 +618,7 @@ st_draw_vbo(GLcontext *ctx,
          /* elements/indexes are in a real VBO */
          struct st_buffer_object *stobj = st_buffer_object(bufobj);
          pipe_buffer_reference(&indexBuf, stobj->buffer);
-         indexOffset = (unsigned) ib->ptr / indexSize;
+         indexOffset = pointer_to_offset(ib->ptr) / indexSize;
       }
       else {
          /* element/indicies are in user space memory */
diff --git a/src/mesa/state_tracker/st_draw.h b/src/mesa/state_tracker/st_draw.h
index 659c3ac..da04fce 100644
--- a/src/mesa/state_tracker/st_draw.h
+++ b/src/mesa/state_tracker/st_draw.h
@@ -64,4 +64,19 @@ st_feedback_draw_vbo(GLcontext *ctx,
 extern GLuint
 st_pipe_vertex_format(GLenum type, GLuint size, GLboolean normalized);
 
+
+/**
+ * When drawing with VBOs, the addresses specified with
+ * glVertex/Color/TexCoordPointer() are really offsets into the VBO, not real
+ * addresses.  At some point we need to convert those pointers to offsets.
+ * This function is basically a cast wrapper to avoid warnings when building
+ * in 64-bit mode.
+ */
+static INLINE unsigned
+pointer_to_offset(const void *ptr)
+{
+   return (unsigned) (((unsigned long) ptr) & 0xffffffffUL);
+}
+
+
 #endif
diff --git a/src/mesa/state_tracker/st_draw_feedback.c b/src/mesa/state_tracker/st_draw_feedback.c
index d63d8ca..e533afd 100644
--- a/src/mesa/state_tracker/st_draw_feedback.c
+++ b/src/mesa/state_tracker/st_draw_feedback.c
@@ -153,7 +153,7 @@ st_feedback_draw_vbo(GLcontext *ctx,
 
          vbuffers[attr].buffer = NULL;
          pipe_buffer_reference(&vbuffers[attr].buffer, stobj->buffer);
-         vbuffers[attr].buffer_offset = (unsigned) arrays[0]->Ptr;/* in bytes */
+         vbuffers[attr].buffer_offset = pointer_to_offset(arrays[0]->Ptr);
          velements[attr].src_offset = arrays[mesaAttr]->Ptr - arrays[0]->Ptr;
       }
       else {




More information about the mesa-commit mailing list