Mesa (master): st: update texture comments

Brian Paul brianp at kemper.freedesktop.org
Wed Mar 18 16:24:41 UTC 2009


Module: Mesa
Branch: master
Commit: 3151f5d75ac26d4460b6905ecad0a8ac0470e419
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3151f5d75ac26d4460b6905ecad0a8ac0470e419

Author: Brian Paul <brianp at vmware.com>
Date:   Wed Mar 18 09:40:37 2009 -0600

st: update texture comments

---

 src/mesa/state_tracker/st_texture.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/mesa/state_tracker/st_texture.c b/src/mesa/state_tracker/st_texture.c
index b9b5bae..6f274d6 100644
--- a/src/mesa/state_tracker/st_texture.c
+++ b/src/mesa/state_tracker/st_texture.c
@@ -114,10 +114,7 @@ st_texture_create(struct st_context *st,
 
 
 /**
- * Check if a texture image be pulled into a unified mipmap texture.
- * This mirrors the completeness test in a lot of ways.
- *
- * Not sure whether I want to pass gl_texture_image here.
+ * Check if a texture image can be pulled into a unified mipmap texture.
  */
 GLboolean
 st_texture_match_image(const struct pipe_texture *pt,
@@ -129,13 +126,14 @@ st_texture_match_image(const struct pipe_texture *pt,
    if (image->Border) 
       return GL_FALSE;
 
+   /* Check if this image's format matches the established texture's format.
+    */
    if (st_mesa_format_to_pipe_format(image->TexFormat->MesaFormat) != pt->format ||
        image->IsCompressed != pt->compressed)
       return GL_FALSE;
 
-   /* Test image dimensions against the base level image adjusted for
-    * minification.  This will also catch images not present in the
-    * texture, changed targets, etc.
+   /* Test if this image's size matches what's expected in the
+    * established texture.
     */
    if (image->Width != pt->width[level] ||
        image->Height != pt->height[level] ||




More information about the mesa-commit mailing list