Mesa (master): intel: Don' t segfault on glGenerateMipmaps of a cube map with one face defined.

Eric Anholt anholt at kemper.freedesktop.org
Thu May 21 17:48:29 UTC 2009


Module: Mesa
Branch: master
Commit: 467f18f7a5375af9a31031063536c927df3ea70c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=467f18f7a5375af9a31031063536c927df3ea70c

Author: Eric Anholt <eric at anholt.net>
Date:   Wed May 20 14:00:32 2009 -0700

intel: Don't segfault on glGenerateMipmaps of a cube map with one face defined.

This presumably applies to SGIS_generate_mipmaps as well.

---

 src/mesa/drivers/dri/intel/intel_tex_validate.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_tex_validate.c b/src/mesa/drivers/dri/intel/intel_tex_validate.c
index 05a375e..b5cb759 100644
--- a/src/mesa/drivers/dri/intel/intel_tex_validate.c
+++ b/src/mesa/drivers/dri/intel/intel_tex_validate.c
@@ -241,7 +241,7 @@ intel_tex_map_level_images(struct intel_context *intel,
       struct intel_texture_image *intelImage =
 	 intel_texture_image(intelObj->base.Image[face][level]);
 
-      if (intelImage->mt) {
+      if (intelImage && intelImage->mt) {
 	 intelImage->base.Data =
 	    intel_miptree_image_map(intel,
 				    intelImage->mt,
@@ -268,7 +268,7 @@ intel_tex_unmap_level_images(struct intel_context *intel,
       struct intel_texture_image *intelImage =
 	 intel_texture_image(intelObj->base.Image[face][level]);
 
-      if (intelImage->mt) {
+      if (intelImage && intelImage->mt) {
 	 intel_miptree_image_unmap(intel, intelImage->mt);
 	 intelImage->base.Data = NULL;
       }




More information about the mesa-commit mailing list