Mesa (master): r300g: Comments.

[Corbin Simpson]

Module: Mesa
Branch: master
Commit: cd5b2a93d5c9c60dbe72ebc963dcddf0db0b665c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd5b2a93d5c9c60dbe72ebc963dcddf0db0b665c

Author: Corbin Simpson <MostAwesomeDude at gmail.com>
Date:   Sat Nov  7 10:52:06 2009 -0800

r300g: Comments.

---

 src/gallium/drivers/r300/r300_render.c |    3 ++-
 src/gallium/drivers/r300/r300_vbo.c    |   14 +++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/gallium/drivers/r300/r300_render.c b/src/gallium/drivers/r300/r300_render.c
index 89bf749..0df9a94 100644
--- a/src/gallium/drivers/r300/r300_render.c
+++ b/src/gallium/drivers/r300/r300_render.c
@@ -243,7 +243,8 @@ boolean r300_draw_arrays(struct pipe_context* pipe, unsigned mode,
  * keep these functions separated so that they are easier to locate. ~C.    *
  ***************************************************************************/
 
-/* Draw-based drawing for SW TCL chipsets. */
+/* Draw-based drawing for SW TCL chipsets.
+ * XXX currently broken as fucking hell. */
 boolean r300_swtcl_draw_range_elements(struct pipe_context* pipe,
                                        struct pipe_buffer* indexBuffer,
                                        unsigned indexSize,
diff --git a/src/gallium/drivers/r300/r300_vbo.c b/src/gallium/drivers/r300/r300_vbo.c
index cec79ec..d8b356a 100644
--- a/src/gallium/drivers/r300/r300_vbo.c
+++ b/src/gallium/drivers/r300/r300_vbo.c
@@ -21,6 +21,9 @@
  * USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
+/* r300_vbo: Various helpers for emitting vertex buffers. Needs cleanup,
+ * refactoring, etc. */
+
 #include "r300_vbo.h"
 
 #include "pipe/p_format.h"
@@ -76,6 +79,7 @@ void setup_vertex_attributes(struct r300_context *r300)
     finish_vertex_attribs_setup(r300->vertex_info, r300->aos_count);
 }
 
+/* XXX WTF are these doing? */
 static void setup_vertex_array(struct r300_context *r300, struct pipe_vertex_element *element)
 {
 }
@@ -84,6 +88,7 @@ static void finish_vertex_arrays_setup(struct r300_context *r300)
 {
 }
 
+/* XXX move/integrate this with the checks in r300_state_inlines */
 static boolean format_is_supported(enum pipe_format format, int nr_components)
 {
     if (pf_layout(format) != PIPE_FORMAT_LAYOUT_RGBAZS)
@@ -151,16 +156,15 @@ void setup_index_buffer(struct r300_context *r300,
                         struct pipe_buffer* indexBuffer,
                         unsigned indexSize)
 {
+    /* XXX I call BS; why is this different from the assert in r300_render? */
     assert(indexSize = 2);
 
-    if (!r300->winsys->add_buffer(r300->winsys, indexBuffer, RADEON_GEM_DOMAIN_GTT, 0))
-    {
+    if (!r300->winsys->add_buffer(r300->winsys, indexBuffer,
+                                  RADEON_GEM_DOMAIN_GTT, 0)) {
         assert(0);
     }
 
-    if (!r300->winsys->validate(r300->winsys))
-    {
+    if (!r300->winsys->validate(r300->winsys)) {
         assert(0);
     }
 }
-