Mesa (mesa_7_6_branch): mesa: fix potential uninitialized memory reads

Brian Paul brianp at kemper.freedesktop.org
Thu Oct 1 20:56:24 UTC 2009


Module: Mesa
Branch: mesa_7_6_branch
Commit: 7b568614a28cb0b0fec375e79aebf51a6f210b44
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b568614a28cb0b0fec375e79aebf51a6f210b44

Author: Brian Paul <brianp at vmware.com>
Date:   Thu Oct  1 14:51:26 2009 -0600

mesa: fix potential uninitialized memory reads

---

 src/mesa/main/dlist.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index b53c173..41a5b61 100644
--- a/src/mesa/main/dlist.c
+++ b/src/mesa/main/dlist.c
@@ -1956,6 +1956,9 @@ save_Fogiv(GLenum pname, const GLint *params)
    case GL_FOG_END:
    case GL_FOG_INDEX:
       p[0] = (GLfloat) *params;
+      p[1] = 0.0f;
+      p[2] = 0.0f;
+      p[3] = 0.0f;
       break;
    case GL_FOG_COLOR:
       p[0] = INT_TO_FLOAT(params[0]);
@@ -2244,6 +2247,9 @@ save_LightModeliv(GLenum pname, const GLint *params)
    case GL_LIGHT_MODEL_TWO_SIDE:
    case GL_LIGHT_MODEL_COLOR_CONTROL:
       fparam[0] = (GLfloat) params[0];
+      fparam[1] = 0.0F;
+      fparam[2] = 0.0F;
+      fparam[3] = 0.0F;
       break;
    default:
       /* Error will be caught later in gl_LightModelfv */




More information about the mesa-commit mailing list