Mesa (mesa_7_5_branch): st/mesa: fix some incorrect branching/ clean-up code in TexImage functions

Brian Paul brianp at kemper.freedesktop.org
Wed Sep 16 19:08:46 UTC 2009


Module: Mesa
Branch: mesa_7_5_branch
Commit: 08d39251a79a964e4a3ac0d7d8a397c2b66a0808
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=08d39251a79a964e4a3ac0d7d8a397c2b66a0808

Author: Brian Paul <brianp at vmware.com>
Date:   Wed Sep 16 13:07:12 2009 -0600

st/mesa: fix some incorrect branching/clean-up code in TexImage functions

We need to be sure to call the _mesa_unmap_teximage_pbo() function if we
called _mesa_validate_pbo_teximage().

---

 src/mesa/state_tracker/st_cb_texture.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c
index 31196fe..cfa33d4 100644
--- a/src/mesa/state_tracker/st_cb_texture.c
+++ b/src/mesa/state_tracker/st_cb_texture.c
@@ -764,9 +764,9 @@ st_TexImage(GLcontext * ctx,
       }
    }
 
+done:
    _mesa_unmap_teximage_pbo(ctx, unpack);
 
-done:
    if (stImage->pt && texImage->Data) {
       st_texture_image_unmap(ctx->st, stImage);
       texImage->Data = NULL;
@@ -1107,7 +1107,7 @@ st_TexSubimage(GLcontext *ctx, GLint dims, GLenum target, GLint level,
 
    if (!texImage->Data) {
       _mesa_error(ctx, GL_OUT_OF_MEMORY, "glTexSubImage");
-      return;
+      goto done;
    }
 
    src = (const GLubyte *) pixels;
@@ -1138,9 +1138,9 @@ st_TexSubimage(GLcontext *ctx, GLint dims, GLenum target, GLint level,
       }
    }
 
+done:
    _mesa_unmap_teximage_pbo(ctx, packing);
 
-done:
    if (stImage->pt) {
       st_texture_image_unmap(ctx->st, stImage);
       texImage->Data = NULL;




More information about the mesa-commit mailing list