Mesa (master): vbo: added comment about max array index
Brian Paul
brianp at kemper.freedesktop.org
Mon Sep 21 22:56:36 UTC 2009
Module: Mesa
Branch: master
Commit: 94a020cfe6cb1da04695897eed38b530af31f524
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=94a020cfe6cb1da04695897eed38b530af31f524
Author: Brian Paul <brianp at vmware.com>
Date: Mon Sep 21 16:54:35 2009 -0600
vbo: added comment about max array index
---
src/mesa/vbo/vbo_exec_array.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c
index ee37eeb..668dc6e 100644
--- a/src/mesa/vbo/vbo_exec_array.c
+++ b/src/mesa/vbo/vbo_exec_array.c
@@ -678,6 +678,12 @@ vbo_exec_DrawRangeElementsBaseVertex(GLenum mode,
type, indices, basevertex ))
return;
+ /* NOTE: It's important that 'end' is a reasonable value.
+ * in _tnl_draw_prims(), we use end to determine how many vertices
+ * to transform. If it's too large, we can unnecessarily split prims
+ * or we can read/write out of memory in several different places!
+ */
+
if (end >= ctx->Array.ArrayObj->_MaxElement) {
/* the max element is out of bounds of one or more enabled arrays */
_mesa_warning(ctx, "glDraw[Range]Elements(start %u, end %u, count %d, "
More information about the mesa-commit
mailing list