Mesa (master): r300g: Expound on dithering comment.

Corbin Simpson csimpson at kemper.freedesktop.org
Fri Apr 2 21:24:55 UTC 2010


Module: Mesa
Branch: master
Commit: 21961f6e9614f234be704da93032cb4ec197eef4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=21961f6e9614f234be704da93032cb4ec197eef4

Author: Corbin Simpson <MostAwesomeDude at gmail.com>
Date:   Fri Apr  2 14:21:50 2010 -0700

r300g: Expound on dithering comment.

---

 src/gallium/drivers/r300/r300_state.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/r300/r300_state.c b/src/gallium/drivers/r300/r300_state.c
index bf17d5d..2c0a7d8 100644
--- a/src/gallium/drivers/r300/r300_state.c
+++ b/src/gallium/drivers/r300/r300_state.c
@@ -320,12 +320,17 @@ static void* r300_create_blend_state(struct pipe_context* pipe,
         }
     }
 
+    /* Neither fglrx nor classic r300 ever set this, regardless of dithering
+     * state. Since it's an optional implementation detail, we can leave it
+     * out and never dither.
+     *
+     * This could be revisited if we ever get quality or conformance hints.
+     *
     if (state->dither) {
-	/* fglrx appears to never set this */
-	blend->dither = 0;
-        /* blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT |
-                           R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT; */
+        blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT |
+                        R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT;
     }
+    */
 
     return (void*)blend;
 }




More information about the mesa-commit mailing list