Mesa (glsl2): glcpp: Discard output of cmp when running the test suite.

Carl Worth cworth at kemper.freedesktop.org
Wed Aug 11 01:38:04 UTC 2010


Module: Mesa
Branch: glsl2
Commit: 9b7fd2099f926b9cc187382ca75eb8dedf3d37ca
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b7fd2099f926b9cc187382ca75eb8dedf3d37ca

Author: Carl Worth <cworth at cworth.org>
Date:   Tue Aug 10 18:27:31 2010 -0700

glcpp: Discard output of cmp when running the test suite.

We're already using the return-value of cmp to print either PASS or
FAIL and in the case of failure, we're subsequently running and
showing the output of diff. So any warnings/errors from cmp itself are
not actually needed, and can be quite confusing.

---

 src/glsl/glcpp/tests/glcpp-test |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/glsl/glcpp/tests/glcpp-test b/src/glsl/glcpp/tests/glcpp-test
index cfe7e97..c09e8a9 100755
--- a/src/glsl/glcpp/tests/glcpp-test
+++ b/src/glsl/glcpp/tests/glcpp-test
@@ -9,7 +9,7 @@ for test in *.c; do
     echo -n "Testing $test..."
     ../glcpp < $test > $test.out
     total=$((total+1))
-    if cmp $test.expected $test.out; then
+    if cmp $test.expected $test.out >/dev/null 2>&1; then
 	echo "PASS"
 	pass=$((pass+1))
     else




More information about the mesa-commit mailing list