Mesa (master): nv50: fix 2 off by one memory leaks (nv50_miptree_level-> image_offset)

Christoph Bumiller chrisbmr at kemper.freedesktop.org
Tue Jan 12 16:43:38 UTC 2010


Module: Mesa
Branch: master
Commit: 90762bd3550338368d989c0b212c10b6e33b023b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=90762bd3550338368d989c0b212c10b6e33b023b

Author: Marcin Slusarz <marcin.slusarz at gmail.com>
Date:   Tue Jan 12 17:39:23 2010 +0100

nv50: fix 2 off by one memory leaks (nv50_miptree_level->image_offset)

---

 src/gallium/drivers/nv50/nv50_miptree.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/nv50/nv50_miptree.c b/src/gallium/drivers/nv50/nv50_miptree.c
index 3f1edf0..cecb1ef 100644
--- a/src/gallium/drivers/nv50/nv50_miptree.c
+++ b/src/gallium/drivers/nv50/nv50_miptree.c
@@ -145,7 +145,7 @@ nv50_miptree_create(struct pipe_screen *pscreen, const struct pipe_texture *tmp)
 				  mt->level[0].tile_mode, tile_flags,
 				  &mt->base.bo);
 	if (ret) {
-		for (l = 0; l < pt->last_level; ++l)
+		for (l = 0; l <= pt->last_level; ++l)
 			FREE(mt->level[l].image_offset);
 		FREE(mt);
 		return NULL;
@@ -188,7 +188,7 @@ nv50_miptree_destroy(struct pipe_texture *pt)
 	struct nv50_miptree *mt = nv50_miptree(pt);
 	unsigned l;
 
-	for (l = 0; l < pt->last_level; ++l)
+	for (l = 0; l <= pt->last_level; ++l)
 		FREE(mt->level[l].image_offset);
 
 	nouveau_bo_ref(NULL, &mt->base.bo);




More information about the mesa-commit mailing list