Mesa (master): radeon_compiler: include main/compiler. h for compiler portability macros

Brian Paul brianp at vmware.com
Mon Jan 18 17:33:17 UTC 2010


Corbin Simpson wrote:
> Module: Mesa
> Branch: master
> Commit: 816cb90e7c41ee9cc02a8b12f64b368bd0c2fd03
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=816cb90e7c41ee9cc02a8b12f64b368bd0c2fd03
> 
> Author: Alan Coopersmith <alan.coopersmith at sun.com>
> Date:   Sun Jan 17 00:55:39 2010 -0800
> 
> radeon_compiler: include main/compiler.h for compiler portability macros
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
> Reviewed-by: Corbin Simpson <MostAwesomeDude at gmail.com>
> 
> ---
> 
>  .../drivers/dri/r300/compiler/radeon_compiler.h    |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/r300/compiler/radeon_compiler.h b/src/mesa/drivers/dri/r300/compiler/radeon_compiler.h
> index 731adc1..f27f858 100644
> --- a/src/mesa/drivers/dri/r300/compiler/radeon_compiler.h
> +++ b/src/mesa/drivers/dri/r300/compiler/radeon_compiler.h
> @@ -23,6 +23,8 @@
>  #ifndef RADEON_COMPILER_H
>  #define RADEON_COMPILER_H
>  
> +#include "../../../../main/compiler.h"
> +

I'd rather not see relative paths like these in the source code. 
Don't the exising -I options suffice?

Also, isn't the r300 compiler code used by both the old Mesa/DRI 
driver and the new gallium driver?

Perhaps we should include main/compiler.h or pipe/p_compiler.h 
depending on which driver is being built.

-Brian




More information about the mesa-commit mailing list