Mesa (master): r100/r200: fix Y coord flipping in accelerated blits

Alex Deucher agd5f at kemper.freedesktop.org
Wed Jan 20 00:17:38 UTC 2010


Module: Mesa
Branch: master
Commit: 76cf2618327a7f008dcfd0d91d64d6d9e01f9a9c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=76cf2618327a7f008dcfd0d91d64d6d9e01f9a9c

Author: Alex Deucher <alexdeucher at gmail.com>
Date:   Tue Jan 19 19:13:26 2010 -0500

r100/r200: fix Y coord flipping in accelerated blits

---

 src/mesa/drivers/dri/r200/r200_blit.c     |   11 +++++------
 src/mesa/drivers/dri/radeon/radeon_blit.c |   11 +++++------
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/src/mesa/drivers/dri/r200/r200_blit.c b/src/mesa/drivers/dri/r200/r200_blit.c
index 8d9c976..f899f7e 100644
--- a/src/mesa/drivers/dri/r200/r200_blit.c
+++ b/src/mesa/drivers/dri/r200/r200_blit.c
@@ -241,9 +241,8 @@ static inline void calc_tex_coords(float img_width, float img_height,
     buf[3] = buf[2] + reg_height / img_height;
     if (flip_y)
     {
-        float tmp = buf[2];
-        buf[2] = 1.0 - buf[3];
-        buf[3] = 1.0 - tmp;
+        buf[2] = 1.0 - buf[1];
+        buf[3] = 1.0 - buf[3];
     }
 }
 
@@ -266,17 +265,17 @@ static inline void emit_draw_packet(struct r200_context *r200,
     verts[0] = dst_x_offset;
     verts[1] = dst_y_offset + reg_height;
     verts[2] = texcoords[0];
-    verts[3] = texcoords[2];
+    verts[3] = texcoords[3];
 
     verts[4] = dst_x_offset + reg_width;
     verts[5] = dst_y_offset + reg_height;
     verts[6] = texcoords[1];
-    verts[7] = texcoords[2];
+    verts[7] = texcoords[3];
 
     verts[8] = dst_x_offset + reg_width;
     verts[9] = dst_y_offset;
     verts[10] = texcoords[1];
-    verts[11] = texcoords[3];
+    verts[11] = texcoords[2];
 
     BEGIN_BATCH(14);
     OUT_BATCH(R200_CP_CMD_3D_DRAW_IMMD_2 | (12 << 16));
diff --git a/src/mesa/drivers/dri/radeon/radeon_blit.c b/src/mesa/drivers/dri/radeon/radeon_blit.c
index c40f21c..0df4fbb 100644
--- a/src/mesa/drivers/dri/radeon/radeon_blit.c
+++ b/src/mesa/drivers/dri/radeon/radeon_blit.c
@@ -234,9 +234,8 @@ static inline void calc_tex_coords(float img_width, float img_height,
     buf[3] = buf[2] + reg_height / img_height;
     if (flip_y)
     {
-        float tmp = buf[2];
-        buf[2] = 1.0 - buf[3];
-        buf[3] = 1.0 - tmp;
+        buf[2] = 1.0 - buf[2];
+        buf[3] = 1.0 - buf[3];
     }
 }
 
@@ -259,17 +258,17 @@ static inline void emit_draw_packet(struct r100_context *r100,
     verts[0] = dst_x_offset;
     verts[1] = dst_y_offset + reg_height;
     verts[2] = texcoords[0];
-    verts[3] = texcoords[2];
+    verts[3] = texcoords[3];
 
     verts[4] = dst_x_offset + reg_width;
     verts[5] = dst_y_offset + reg_height;
     verts[6] = texcoords[1];
-    verts[7] = texcoords[2];
+    verts[7] = texcoords[3];
 
     verts[8] = dst_x_offset + reg_width;
     verts[9] = dst_y_offset;
     verts[10] = texcoords[1];
-    verts[11] = texcoords[3];
+    verts[11] = texcoords[2];
 
     BEGIN_BATCH(15);
     OUT_BATCH(RADEON_CP_PACKET3_3D_DRAW_IMMD | (13 << 16));




More information about the mesa-commit mailing list