Mesa (master): gallivm: Fix 8bit comparisons.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Tue Jul 6 10:55:34 UTC 2010


Module: Mesa
Branch: master
Commit: b3d4e5bd26a44870af7d2413cca7a6f576a0984a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3d4e5bd26a44870af7d2413cca7a6f576a0984a

Author: José Fonseca <jfonseca at vmware.com>
Date:   Tue Jun 15 15:34:16 2010 +0100

gallivm: Fix 8bit comparisons.

---

 src/gallium/auxiliary/gallivm/lp_bld_logic.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_logic.c b/src/gallium/auxiliary/gallivm/lp_bld_logic.c
index d13fa1a..7f41764 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_logic.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_logic.c
@@ -187,12 +187,10 @@ lp_build_compare(LLVMBuilderRef builder,
             return lp_build_undef(type);
          }
 
-         /* There are no signed byte and unsigned word/dword comparison
-          * instructions. So flip the sign bit so that the results match.
+         /* There are no unsigned comparison instructions. So flip the sign bit
+          * so that the results match.
           */
-         if(table[func].gt &&
-            ((type.width == 8 && type.sign) ||
-             (type.width != 8 && !type.sign))) {
+         if (table[func].gt && !type.sign) {
             LLVMValueRef msb = lp_build_const_int_vec(type, (unsigned long long)1 << (type.width - 1));
             a = LLVMBuildXor(builder, a, msb, "");
             b = LLVMBuildXor(builder, b, msb, "");




More information about the mesa-commit mailing list