Mesa (glsl2): glsl2: Move temp declaration to correct side of if-statement in IR

Ian Romanick idr at kemper.freedesktop.org
Mon Jul 12 22:23:36 UTC 2010


Module: Mesa
Branch: glsl2
Commit: 81d664f099a5fd5fac777480532fb4307d591451
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=81d664f099a5fd5fac777480532fb4307d591451

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Mon Jul 12 15:18:55 2010 -0700

glsl2: Move temp declaration to correct side of if-statement in IR

---

 src/glsl/ast_to_hir.cpp |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index a9ab17f..98090d2 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -805,6 +805,10 @@ ast_expression::hir(exec_list *instructions,
 	 }
 	 type = glsl_type::bool_type;
       } else {
+	 ir_variable *const tmp = new(ctx) ir_variable(glsl_type::bool_type,
+						       "and_tmp");
+	 instructions->push_tail(tmp);
+
 	 ir_if *const stmt = new(ctx) ir_if(op[0]);
 	 instructions->push_tail(stmt);
 
@@ -819,10 +823,6 @@ ast_expression::hir(exec_list *instructions,
 	    error_emitted = true;
 	 }
 
-	 ir_variable *const tmp = new(ctx) ir_variable(glsl_type::bool_type,
-						       "and_tmp");
-	 instructions->push_tail(tmp);
-
 	 ir_dereference *const then_deref = new(ctx) ir_dereference_variable(tmp);
 	 ir_assignment *const then_assign =
 	    new(ctx) ir_assignment(then_deref, op[1], NULL);
@@ -869,13 +869,13 @@ ast_expression::hir(exec_list *instructions,
 	 }
 	 type = glsl_type::bool_type;
       } else {
-	 ir_if *const stmt = new(ctx) ir_if(op[0]);
-	 instructions->push_tail(stmt);
-
 	 ir_variable *const tmp = new(ctx) ir_variable(glsl_type::bool_type,
 						       "or_tmp");
 	 instructions->push_tail(tmp);
 
+	 ir_if *const stmt = new(ctx) ir_if(op[0]);
+	 instructions->push_tail(stmt);
+
 	 op[1] = this->subexpressions[1]->hir(&stmt->then_instructions, state);
 
 	 if (!op[1]->type->is_boolean() || !op[1]->type->is_scalar()) {




More information about the mesa-commit mailing list