Mesa (master): draw: fix some unsigned issue

Zack Rusin zack at kemper.freedesktop.org
Thu Jun 17 02:00:58 PDT 2010


Module: Mesa
Branch: master
Commit: c85971da31276f17f90fe7d7596c24b5daa204f9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c85971da31276f17f90fe7d7596c24b5daa204f9

Author: Zack Rusin <zackr at vmware.com>
Date:   Thu Jun 17 04:59:48 2010 -0400

draw: fix some unsigned issue

spotted by Vinson

---

 src/gallium/auxiliary/draw/draw_pt_so_emit.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/gallium/auxiliary/draw/draw_pt_so_emit.c b/src/gallium/auxiliary/draw/draw_pt_so_emit.c
index 720c105..84555a7 100644
--- a/src/gallium/auxiliary/draw/draw_pt_so_emit.c
+++ b/src/gallium/auxiliary/draw/draw_pt_so_emit.c
@@ -101,10 +101,10 @@ is_component_writable(unsigned mask,
    case TGSI_WRITEMASK_YZW:
       return compo == 1 || compo == 2 || compo == 4;
    case TGSI_WRITEMASK_XYZW:
-      return compo >= 0 && compo < 4;
+      return compo < 4;
    default:
       debug_assert(!"Unknown writemask in stream out");
-      return compo >= 0 && compo < 4;
+      return compo < 4;
    }
 }
 
@@ -162,8 +162,8 @@ static void so_emit_prim(struct pt_so_emit *so,
          total_written_compos += written_compos;
       }
       if (so->single_buffer) {
-         unsigned stride = state->stride -
-                           sizeof(float) * total_written_compos;
+         int stride = (int)state->stride -
+                      sizeof(float) * total_written_compos;
 
          debug_assert(stride >= 0);
          *buffer = (float*) (((char*)*buffer) + stride);



More information about the mesa-commit mailing list