Mesa (master): swrast: fix incorrect specular highlights on backfaces

Brian Paul brianp at kemper.freedesktop.org
Mon Jun 21 16:20:13 PDT 2010


Module: Mesa
Branch: master
Commit: 64e32ffb6e7d324dcb46a18975db0c58719c51e7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=64e32ffb6e7d324dcb46a18975db0c58719c51e7

Author: Tim Evans <t.evans at aranz.com>
Date:   Mon Jun 21 17:18:30 2010 -0600

swrast: fix incorrect specular highlights on backfaces

See bug 28577 for details.
NOTE: this is a candidate for the 7.8 branch.

Signed-off-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/swrast_setup/ss_triangle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/swrast_setup/ss_triangle.c b/src/mesa/swrast_setup/ss_triangle.c
index bad0d81..f22bc52 100644
--- a/src/mesa/swrast_setup/ss_triangle.c
+++ b/src/mesa/swrast_setup/ss_triangle.c
@@ -159,7 +159,7 @@ static void _swsetup_render_tri(GLcontext *ctx,
 }
 
 #define SS_COLOR(a,b) UNCLAMPED_FLOAT_TO_RGBA_CHAN(a,b)
-#define SS_SPEC(a,b) UNCLAMPED_FLOAT_TO_RGB_CHAN(a,b)
+#define SS_SPEC(a,b) COPY_4V(a,b)
 #define SS_IND(a,b) (a = b)
 
 #define IND (0)



More information about the mesa-commit mailing list