Mesa (master): intel: Check that the batch is mapped per BEGIN, not each OUT.

Eric Anholt anholt at kemper.freedesktop.org
Fri Mar 5 23:25:24 UTC 2010


Module: Mesa
Branch: master
Commit: 8a9d8bd52af4414e59320c68238b8929edf3ff80
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a9d8bd52af4414e59320c68238b8929edf3ff80

Author: Eric Anholt <eric at anholt.net>
Date:   Fri Mar  5 12:27:46 2010 -0800

intel: Check that the batch is mapped per BEGIN, not each OUT.

Shaves 800 bytes off the driver.

---

 src/mesa/drivers/dri/intel/intel_batchbuffer.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_batchbuffer.h b/src/mesa/drivers/dri/intel/intel_batchbuffer.h
index 79bdbc1..860aa13 100644
--- a/src/mesa/drivers/dri/intel/intel_batchbuffer.h
+++ b/src/mesa/drivers/dri/intel/intel_batchbuffer.h
@@ -86,7 +86,6 @@ intel_batchbuffer_space(struct intel_batchbuffer *batch)
 static INLINE void
 intel_batchbuffer_emit_dword(struct intel_batchbuffer *batch, GLuint dword)
 {
-   assert(batch->map);
    assert(intel_batchbuffer_space(batch) >= 4);
    *(GLuint *) (batch->ptr) = dword;
    batch->ptr += 4;
@@ -118,6 +117,7 @@ static INLINE uint32_t float_as_int(float f)
 
 #define BEGIN_BATCH(n) do {				\
    intel_batchbuffer_require_space(intel->batch, (n)*4); \
+   assert(intel->batch->map);						\
    assert(intel->batch->emit.start_ptr == NULL);			\
    intel->batch->emit.total = (n) * 4;					\
    intel->batch->emit.start_ptr = intel->batch->ptr;			\




More information about the mesa-commit mailing list