Mesa (master): Revert "glapi: s/strcpy/strncpy/"
Brian Paul
brianp at kemper.freedesktop.org
Mon May 3 19:17:37 UTC 2010
Module: Mesa
Branch: master
Commit: 6405ecb399a52e4d3fe0c002bcd9b3485cbd1360
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6405ecb399a52e4d3fe0c002bcd9b3485cbd1360
Author: Brian Paul <brianp at vmware.com>
Date: Mon May 3 13:16:11 2010 -0600
Revert "glapi: s/strcpy/strncpy/"
This reverts commit 9446fd8f69564e09ffd0f28735a99c510f84bb62.
It doesn't make sense to replace strcpy(a,b) with strncpy(a,b,strlen(b)).
The preceeding code effectively does bounds checking, btw.
---
src/mesa/glapi/glapi_getproc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/mesa/glapi/glapi_getproc.c b/src/mesa/glapi/glapi_getproc.c
index ec96ab3..c73e8dd 100644
--- a/src/mesa/glapi/glapi_getproc.c
+++ b/src/mesa/glapi/glapi_getproc.c
@@ -265,8 +265,7 @@ str_dup(const char *str)
copy = (char*) malloc(strlen(str) + 1);
if (!copy)
return NULL;
- strncpy(copy, str, strlen(str));
- copy[strlen(str)] = '\0';
+ strcpy(copy, str);
return copy;
}
More information about the mesa-commit
mailing list