Mesa (master): intel: Fix the client-side swapbuffers throttling.

Eric Anholt anholt at kemper.freedesktop.org
Tue Nov 9 21:35:27 UTC 2010


Module: Mesa
Branch: master
Commit: 76360d6abc9e0195bc5c373101ae616e68b2e6e6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=76360d6abc9e0195bc5c373101ae616e68b2e6e6

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Nov  9 13:30:27 2010 -0800

intel: Fix the client-side swapbuffers throttling.

We were asking for a wait to GTT read (all GPU rendering to it
complete), instead of asking for all GPU reading from it to be
complete.  Prevents swapbuffers-based apps from running away with
rendering, and produces a better input experience.

---

 src/mesa/drivers/dri/intel/intel_context.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
index de4bcde..60c401b 100644
--- a/src/mesa/drivers/dri/intel/intel_context.c
+++ b/src/mesa/drivers/dri/intel/intel_context.c
@@ -470,7 +470,11 @@ intel_prepare_render(struct intel_context *intel)
     * so we just us the first batch we emitted after the last swap.
     */
    if (intel->need_throttle && intel->first_post_swapbuffers_batch) {
-      drm_intel_bo_wait_rendering(intel->first_post_swapbuffers_batch);
+      /* Can't use drm_intel_bo_wait_rendering, since that only waits
+       * for rendering *to* the buffer, not from it.
+       */
+      drm_intel_gem_bo_map_gtt(intel->first_post_swapbuffers_batch);
+      drm_intel_gem_bo_unmap_gtt(intel->first_post_swapbuffers_batch);
       drm_intel_bo_unreference(intel->first_post_swapbuffers_batch);
       intel->first_post_swapbuffers_batch = NULL;
       intel->need_throttle = GL_FALSE;




More information about the mesa-commit mailing list