Mesa (master): xorg/vmwgfx: Don't clip video to viewport
Thomas Hellstrom
thomash at kemper.freedesktop.org
Fri Nov 26 09:31:41 UTC 2010
Module: Mesa
Branch: master
Commit: 5822484510b45cac2e16d3b220fd33cef6c41a66
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5822484510b45cac2e16d3b220fd33cef6c41a66
Author: Thomas Hellstrom <thellstrom at vmware.com>
Date: Fri Nov 26 10:12:32 2010 +0100
xorg/vmwgfx: Don't clip video to viewport
Since the viewport is not updated on RandR12 mode switches anymore,
clipping to viewport may incorrectly clip away the video.
Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
---
src/gallium/targets/xorg-vmwgfx/vmw_video.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/src/gallium/targets/xorg-vmwgfx/vmw_video.c b/src/gallium/targets/xorg-vmwgfx/vmw_video.c
index 3d90757..7979209 100644
--- a/src/gallium/targets/xorg-vmwgfx/vmw_video.c
+++ b/src/gallium/targets/xorg-vmwgfx/vmw_video.c
@@ -450,7 +450,16 @@ vmw_video_init_adaptor(ScrnInfoPtr pScrn, struct vmw_customizer *vmw)
vmw->video_priv = video;
adaptor->type = XvInputMask | XvImageMask | XvWindowMask;
- adaptor->flags = VIDEO_OVERLAID_IMAGES | VIDEO_CLIP_TO_VIEWPORT;
+
+ /**
+ * Note: CLIP_TO_VIEWPORT was removed from the flags, since with the
+ * crtc/output based modesetting, the viewport is not updated on
+ * RandR modeswitches. Hence the video may incorrectly be clipped away.
+ * The correct approach, (if needed) would be to clip against the
+ * scanout area union of all active crtcs. Revisit if needed.
+ */
+
+ adaptor->flags = VIDEO_OVERLAID_IMAGES;
adaptor->name = "VMware Video Engine";
adaptor->nEncodings = VMWARE_VID_NUM_ENCODINGS;
adaptor->pEncodings = vmwareVideoEncodings;
More information about the mesa-commit
mailing list