Mesa (master): vbo: init prim[] array with memset()

Brian Paul brianp at kemper.freedesktop.org
Fri Apr 15 07:35:23 PDT 2011


Module: Mesa
Branch: master
Commit: 0630593c5fb22fe0f98f2c815c4a315056a9e3d2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0630593c5fb22fe0f98f2c815c4a315056a9e3d2

Author: Brian Paul <brianp at vmware.com>
Date:   Fri Apr 15 08:32:56 2011 -0600

vbo: init prim[] array with memset()

This fixes a Coverity warning about uninitialized data.

---

 src/mesa/vbo/vbo_exec_array.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c
index 6e26e4e..a49cd50 100644
--- a/src/mesa/vbo/vbo_exec_array.c
+++ b/src/mesa/vbo/vbo_exec_array.c
@@ -585,15 +585,11 @@ vbo_draw_arrays(struct gl_context *ctx, GLenum mode, GLint start,
    if (ctx->NewState)
       _mesa_update_state(ctx);
 
+   /* init most fields to zero */
+   memset(prim, 0, sizeof(prim));
    prim[0].begin = 1;
    prim[0].end = 1;
-   prim[0].weak = 0;
-   prim[0].pad = 0;
    prim[0].mode = mode;
-   prim[0].start = 0; /* filled in below */
-   prim[0].count = 0; /* filled in below */
-   prim[0].indexed = 0;
-   prim[0].basevertex = 0;
    prim[0].num_instances = numInstances;
 
    /* Implement the primitive restart index */



More information about the mesa-commit mailing list