Mesa (7.10): i965: Resolve implied moves in brw_dp_READ_4_vs_relative.

Ian Romanick idr at kemper.freedesktop.org
Thu Apr 21 10:38:26 PDT 2011


Module: Mesa
Branch: 7.10
Commit: 0f02b4253d5b3a3bbdfc72711bb9a7c0781061f4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0f02b4253d5b3a3bbdfc72711bb9a7c0781061f4

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Tue Mar 29 05:49:40 2011 -0700

i965: Resolve implied moves in brw_dp_READ_4_vs_relative.

Fixes piglit test glsl-vs-arrays-3 on Sandybridge, as well as garbage
rendering in 3DMarkMobileES 2.0's Taiji demo and GLBenchmark 2.0's
Egypt and PRO demos.

NOTE: This a candidate for stable release branches.  It depends on
commit 9a21bc640188e4078075b9f8e6701853a4f0bbe4.
(cherry picked from commit 9d60a7ce08a67eb8b79c60f829d090ba4a37ed7e)

---

 src/mesa/drivers/dri/i965/brw_eu_emit.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 33b6412..f6838ff 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
@@ -1799,6 +1799,7 @@ void brw_dp_READ_4_vs_relative(struct brw_compile *p,
 			       GLuint bind_table_index)
 {
    struct intel_context *intel = &p->brw->intel;
+   struct brw_reg src = brw_vec8_grf(0, 0);
    int msg_type;
 
    /* Setup MRF[1] with offset into const buffer */
@@ -1815,6 +1816,7 @@ void brw_dp_READ_4_vs_relative(struct brw_compile *p,
 	   addr_reg, brw_imm_d(offset));
    brw_pop_insn_state(p);
 
+   gen6_resolve_implied_move(p, &src, 0);
    struct brw_instruction *insn = next_insn(p, BRW_OPCODE_SEND);
 
    insn->header.predicate_control = BRW_PREDICATE_NONE;
@@ -1823,7 +1825,7 @@ void brw_dp_READ_4_vs_relative(struct brw_compile *p,
    insn->header.mask_control = BRW_MASK_DISABLE;
 
    brw_set_dest(p, insn, dest);
-   brw_set_src0(insn, brw_vec8_grf(0, 0));
+   brw_set_src0(insn, src);
 
    if (intel->gen == 6)
       msg_type = GEN6_DATAPORT_READ_MESSAGE_OWORD_DUAL_BLOCK_READ;



More information about the mesa-commit mailing list