Mesa (master): i965/vs: Don't lower uniform array indexing.

Eric Anholt anholt at
Tue Aug 30 19:10:33 UTC 2011

Module: Mesa
Branch: master
Commit: ddca4592a7fa08cc294403d221a5f329ee4991e9

Author: Eric Anholt <eric at>
Date:   Mon Aug 22 11:48:04 2011 -0700

i965/vs: Don't lower uniform array indexing.

This avoids the massive conditional move array access, and brings code
generation quality for the new VS backend into the realm of efficiency
of the old backend (roughly 20% more instructions generated than
before across shader-db, instead of assertion failing for generating
over 10,000 instructions on many shaders!).

Reviewed-by: Kenneth Graunke <kenneth at>


 src/mesa/drivers/dri/i965/brw_shader.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
index 597c4cd..0a21094 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.cpp
+++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
@@ -119,7 +119,7 @@ brw_link_shader(struct gl_context *ctx, struct gl_shader_program *prog)
       bool input = true;
       bool output = stage == MESA_SHADER_FRAGMENT;
       bool temp = stage == MESA_SHADER_FRAGMENT;
-      bool uniform = true;
+      bool uniform = stage == MESA_SHADER_FRAGMENT;
 					  input, output, temp, uniform);

More information about the mesa-commit mailing list