Mesa (7.11): glsl: Silence "ast_to_hir.cpp:1984:25: warning: comparison of unsigned expression >= 0 is always true"

Ian Romanick idr at kemper.freedesktop.org
Fri Dec 23 01:02:37 UTC 2011


Module: Mesa
Branch: 7.11
Commit: 42d1a7b3de0907945a09ecc797afb01450da321e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=42d1a7b3de0907945a09ecc797afb01450da321e

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Sun Aug 21 15:44:35 2011 -0700

glsl: Silence "ast_to_hir.cpp:1984:25: warning: comparison of unsigned expression >= 0 is always true"

ast_type_qualifier::location should have been a signed integer from
the beginning, and the giant comment in
apply_type_qualifier_to_variable explains why.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40207
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit f0dd21ac88c0ee0a7dd96012881deeb3172974b6)

---

 src/glsl/ast.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index d1de227..532347d 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -372,7 +372,7 @@ struct ast_type_qualifier {
     * \note
     * This field is only valid if \c explicit_location is set.
     */
-   unsigned location;
+   int location;
 
    /**
     * Return true if and only if an interpolation qualifier is present.




More information about the mesa-commit mailing list