Mesa (master): mesa/st: Fix vertex buffer leak

Thomas Hellstrom thomash at kemper.freedesktop.org
Tue Feb 8 10:02:01 UTC 2011


Module: Mesa
Branch: master
Commit: bb1036aae5b31af583b9aa263fec73c899383493
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bb1036aae5b31af583b9aa263fec73c899383493

Author: Thomas Hellstrom <thellstrom at vmware.com>
Date:   Mon Feb  7 15:37:05 2011 +0100

mesa/st: Fix vertex buffer leak

Make sure we unreference the vertex buffer pointers in a local array.
This fixes huge vertex buffer / memory leaks in mesa demos "fire" and "engine".

NOTE: This is a candidate for the 7.9 and 7.10 branches.

Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>

---

 src/mesa/state_tracker/st_draw_feedback.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/mesa/state_tracker/st_draw_feedback.c b/src/mesa/state_tracker/st_draw_feedback.c
index 4e76a05..c11c769 100644
--- a/src/mesa/state_tracker/st_draw_feedback.c
+++ b/src/mesa/state_tracker/st_draw_feedback.c
@@ -261,6 +261,7 @@ st_feedback_draw_vbo(struct gl_context *ctx,
          pipe_buffer_unmap(pipe, vb_transfer[i]);
          pipe_resource_reference(&draw->pt.vertex_buffer[i].buffer, NULL);
          draw_set_mapped_vertex_buffer(draw, i, NULL);
+         pipe_resource_reference(&vbuffers[i].buffer, NULL);
       }
    }
 




More information about the mesa-commit mailing list