Mesa (master): glsl: Mark 'in' variables at global scope as read-only
Chad Versace
chadversary at kemper.freedesktop.org
Fri Jan 21 22:07:00 UTC 2011
Module: Mesa
Branch: master
Commit: 01a584d09350d2c726312e2c9e88c5dbc54bdb70
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=01a584d09350d2c726312e2c9e88c5dbc54bdb70
Author: Chad Versace <chad.versace at intel.com>
Date: Thu Jan 20 14:12:16 2011 -0800
glsl: Mark 'in' variables at global scope as read-only
Fixes Piglit tests:
spec/glsl-1.30/compiler/storage-qualifiers/static-write-centroid-in-01.frag
spec/glsl-1.30/compiler/storage-qualifiers/static-write-in-01.frag
spec/glsl-1.30/compiler/storage-qualifiers/static-write-in-02.frag
---
src/glsl/ast_to_hir.cpp | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 7a171f3..dfb016c 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -1809,7 +1809,6 @@ apply_type_qualifier_to_variable(const struct ast_type_qualifier *qual,
}
}
- /* FINISHME: Mark 'in' variables at global scope as read-only. */
if (qual->flags.q.constant || qual->flags.q.attribute
|| qual->flags.q.uniform
|| (qual->flags.q.varying && (state->target == fragment_shader)))
@@ -2206,6 +2205,8 @@ ast_declarator_list::hir(exec_list *instructions,
mode, var->name, extra);
}
} else if (var->mode == ir_var_in) {
+ var->read_only = true;
+
if (state->target == vertex_shader) {
bool error_emitted = false;
More information about the mesa-commit
mailing list