Mesa (master): mesa/st: Fix piglit read-front with new drawable invalidation v2

Thomas Hellstrom thomash at kemper.freedesktop.org
Fri Jul 8 06:39:00 UTC 2011


Module: Mesa
Branch: master
Commit: a65e9706035c0e348307e76fdeeed0910ec8c68e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a65e9706035c0e348307e76fdeeed0910ec8c68e

Author: Thomas Hellstrom <thellstrom at vmware.com>
Date:   Fri Jul  8 08:26:29 2011 +0200

mesa/st: Fix piglit read-front with new drawable invalidation v2

When the state tracker adds a front buffer, nothing triggers a validate
drawable call, since the state tracker manager is never notified.

Force a validate drawable call by invalidating the framebuffer's stamp, so
that the window system's renderbuffer (if any) is picked up.

This fixes bug 38988
https://bugs.freedesktop.org/show_bug.cgi?id=38988

Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>

---

 src/mesa/state_tracker/st_manager.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c
index a8c4b5c..7bd82aa 100644
--- a/src/mesa/state_tracker/st_manager.c
+++ b/src/mesa/state_tracker/st_manager.c
@@ -918,6 +918,15 @@ st_manager_add_color_renderbuffer(struct st_context *st,
       return FALSE;
 
    st_framebuffer_update_attachments(stfb);
+
+   /*
+    * Force a call to the state tracker manager to validate the
+    * new renderbuffer. It might be that there is a window system
+    * renderbuffer available.
+    */
+   if(stfb->iface)
+      stfb->iface_stamp = p_atomic_read(&stfb->iface->stamp) - 1;
+
    st_invalidate_state(st->ctx, _NEW_BUFFERS);
 
    return TRUE;




More information about the mesa-commit mailing list