Mesa (master): i965/gen7: Don't emit 3DSTATE_GS_SVB_INDEX on Ivybridge.

Kenneth Graunke kwg at kemper.freedesktop.org
Wed Jun 8 21:52:33 UTC 2011


Module: Mesa
Branch: master
Commit: 2a638076165eaa1294708a7e4518c2d72560e066
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a638076165eaa1294708a7e4518c2d72560e066

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Jun  6 10:35:58 2011 -0700

i965/gen7: Don't emit 3DSTATE_GS_SVB_INDEX on Ivybridge.

According to vol2a.07, it only applies from Cantiga to Sandybridge.

I found this in my ringbuffers while investigating various GPU hangs.
While it may not have been the cause, it seemed wise to remove it.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_misc_state.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c
index 4256234..a6de28b 100644
--- a/src/mesa/drivers/dri/i965/brw_misc_state.c
+++ b/src/mesa/drivers/dri/i965/brw_misc_state.c
@@ -606,13 +606,15 @@ static void upload_invarient_state( struct brw_context *brw )
       OUT_BATCH(1);
       ADVANCE_BATCH();
 
-      for (i = 0; i < 4; i++) {
-	 BEGIN_BATCH(4);
-	 OUT_BATCH(_3DSTATE_GS_SVB_INDEX << 16 | (4 - 2));
-	 OUT_BATCH(i << SVB_INDEX_SHIFT);
-	 OUT_BATCH(0);
-	 OUT_BATCH(0xffffffff);
-	 ADVANCE_BATCH();
+      if (intel->gen < 7) {
+	 for (i = 0; i < 4; i++) {
+	    BEGIN_BATCH(4);
+	    OUT_BATCH(_3DSTATE_GS_SVB_INDEX << 16 | (4 - 2));
+	    OUT_BATCH(i << SVB_INDEX_SHIFT);
+	    OUT_BATCH(0);
+	    OUT_BATCH(0xffffffff);
+	    ADVANCE_BATCH();
+	 }
       }
    }
 




More information about the mesa-commit mailing list