Mesa (master): scons: Accept verbose=yes instead of quiet=no.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Fri Jun 17 19:13:45 UTC 2011


Module: Mesa
Branch: master
Commit: c7bd0fa4851187c3102948f5f4d70c26d1b55a5e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7bd0fa4851187c3102948f5f4d70c26d1b55a5e

Author: José Fonseca <jfonseca at vmware.com>
Date:   Fri Jun 17 18:42:39 2011 +0100

scons: Accept verbose=yes instead of quiet=no.

'verbose' is affirmative, and much more common name for this sort of option.

---

 common.py       |    3 ++-
 scons/custom.py |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/common.py b/common.py
index 052929e..f218e6f 100644
--- a/common.py
+++ b/common.py
@@ -79,7 +79,7 @@ def AddOptions(opts):
 		from SCons.Options.EnumOption import EnumOption
 	opts.Add(EnumOption('build', 'build type', 'debug',
 	                  allowed_values=('debug', 'checked', 'profile', 'release')))
-	opts.Add(BoolOption('quiet', 'quiet command lines', 'yes'))
+	opts.Add(BoolOption('verbose', 'verbose output', 'no'))
 	opts.Add(EnumOption('machine', 'use machine-specific assembly code', default_machine,
 											 allowed_values=('generic', 'ppc', 'x86', 'x86_64')))
 	opts.Add(EnumOption('platform', 'target platform', host_platform,
@@ -90,4 +90,5 @@ def AddOptions(opts):
 	opts.Add(BoolOption('llvm', 'use LLVM', default_llvm))
 	opts.Add(BoolOption('debug', 'DEPRECATED: debug build', 'yes'))
 	opts.Add(BoolOption('profile', 'DEPRECATED: profile build', 'no'))
+	opts.Add(BoolOption('quiet', 'DEPRECATED: quiet command lines', 'yes'))
 	opts.Add(EnumOption('MSVS_VERSION', 'MS Visual C++ version', None, allowed_values=('7.1', '8.0', '9.0')))
diff --git a/scons/custom.py b/scons/custom.py
index a2c690f..029f99b 100644
--- a/scons/custom.py
+++ b/scons/custom.py
@@ -157,7 +157,8 @@ def createCodeGenerateMethod(env):
 def generate(env):
     """Common environment generation code"""
 
-    if env.get('quiet', True):
+    verbose = env.get('verbose', False) or not env.get('quiet', True)
+    if not verbose:
         quietCommandLines(env)
 
     # Custom builders and methods




More information about the mesa-commit mailing list