Mesa (master): i915g: switch to the exact batch space reservation code

Daniel Vetter danvet at kemper.freedesktop.org
Tue Mar 1 21:17:57 UTC 2011


Module: Mesa
Branch: master
Commit: ee7acf6493e934dbc78d98738195a3804c23722e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ee7acf6493e934dbc78d98738195a3804c23722e

Author: Daniel Vetter <daniel.vetter at ffwll.ch>
Date:   Sat Feb 26 17:14:17 2011 +0100

i915g: switch to the exact batch space reservation code

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

---

 src/gallium/drivers/i915/i915_state_emit.c |   23 +++++------------------
 1 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/src/gallium/drivers/i915/i915_state_emit.c b/src/gallium/drivers/i915/i915_state_emit.c
index 504b60c..cefc4d3 100644
--- a/src/gallium/drivers/i915/i915_state_emit.c
+++ b/src/gallium/drivers/i915/i915_state_emit.c
@@ -404,20 +404,6 @@ i915_emit_hardware_state(struct i915_context *i915 )
 {
    unsigned batch_space;
    /* XXX: there must be an easier way */
-   const unsigned dwords = ( 14 + 
-                             7 + 
-                             I915_MAX_DYNAMIC + 
-                             8 + 
-                             2 + I915_TEX_UNITS*3 + 
-                             2 + I915_TEX_UNITS*3 +
-                             2 + I915_MAX_CONSTANT*4 + 
-#if 0
-                             i915->current.program_len + 
-#else
-                             i915->fs->program_len + 
-#endif
-                             6 
-                           ) * 3/2; /* plus 50% margin */
    const unsigned relocs = ( I915_TEX_UNITS +
                              3
                            ) * 3/2; /* plus 50% margin */
@@ -433,10 +419,10 @@ i915_emit_hardware_state(struct i915_context *i915 )
       assert(i915_validate_state(i915, &batch_space));
    }
 
-   if(!BEGIN_BATCH(batch_space + dwords, relocs)) {
+   if(!BEGIN_BATCH(batch_space, relocs)) {
       FLUSH_BATCH(NULL);
       assert(i915_validate_state(i915, &batch_space));
-      assert(BEGIN_BATCH(batch_space + dwords, relocs));
+      assert(BEGIN_BATCH(batch_space, relocs));
    }
 
    save_ptr = (uintptr_t)i915->batch->ptr;
@@ -457,9 +443,10 @@ i915_emit_hardware_state(struct i915_context *i915 )
    EMIT_ATOM(draw_rect, I915_HW_STATIC);
 #undef EMIT_ATOM
 
-   I915_DBG(DBG_EMIT, "%s: used %d dwords, %d relocs\n", __FUNCTION__,
+   I915_DBG(DBG_EMIT, "%s: used %d dwords, %d dwords reserved\n", __FUNCTION__,
             ((uintptr_t)i915->batch->ptr - save_ptr) / 4,
-            i915->batch->relocs - save_relocs);
+            batch_space);
+   assert(((uintptr_t)i915->batch->ptr - save_ptr) / 4 == batch_space);
 
    i915->hardware_dirty = 0;
    i915->immediate_dirty = 0;




More information about the mesa-commit mailing list