Mesa (master): st/mesa: cleanup checking for signed compressed formats in generate_mipmaps

Marek Olšák mareko at kemper.freedesktop.org
Tue Mar 8 23:16:29 UTC 2011


Module: Mesa
Branch: master
Commit: b0ec461954d87085cd31dfe92a9e13a4e5df5aa5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b0ec461954d87085cd31dfe92a9e13a4e5df5aa5

Author: Marek Olšák <maraeo at gmail.com>
Date:   Mon Mar  7 20:23:05 2011 +0100

st/mesa: cleanup checking for signed compressed formats in generate_mipmaps

---

 src/mesa/state_tracker/st_gen_mipmap.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker/st_gen_mipmap.c
index f8b23d1..899161e 100644
--- a/src/mesa/state_tracker/st_gen_mipmap.c
+++ b/src/mesa/state_tracker/st_gen_mipmap.c
@@ -204,14 +204,10 @@ fallback_generate_mipmap(struct gl_context *ctx, GLenum target,
       _mesa_is_format_compressed(texObj->Image[face][baseLevel]->TexFormat);
 
    if (compressed) {
-      if (texObj->Image[face][baseLevel]->TexFormat == MESA_FORMAT_SIGNED_RED_RGTC1 ||
-          texObj->Image[face][baseLevel]->TexFormat == MESA_FORMAT_SIGNED_RG_RGTC2 ||
-          texObj->Image[face][baseLevel]->TexFormat == MESA_FORMAT_SIGNED_L_LATC1 ||
-          texObj->Image[face][baseLevel]->TexFormat == MESA_FORMAT_SIGNED_LA_LATC2)
-         datatype = GL_FLOAT;
-      else
-         datatype = GL_UNSIGNED_BYTE;
-      
+      GLenum type =
+         _mesa_get_format_datatype(texObj->Image[face][baseLevel]->TexFormat);
+
+      datatype = type == GL_UNSIGNED_NORMALIZED ? GL_UNSIGNED_BYTE : GL_FLOAT;
       comps = 4;
    }
    else {




More information about the mesa-commit mailing list