Mesa (master): intel: Drop doubly irrelevant code in intelReadBuffers.
Eric Anholt
anholt at kemper.freedesktop.org
Thu May 26 15:55:26 UTC 2011
Module: Mesa
Branch: master
Commit: c095335fa54498ec54e4587b5f84ad6afd8f1857
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c095335fa54498ec54e4587b5f84ad6afd8f1857
Author: Eric Anholt <eric at anholt.net>
Date: Wed May 25 13:56:04 2011 -0700
intel: Drop doubly irrelevant code in intelReadBuffers.
First, FBO read/draw == NULL validation happens in mesa core not
intelReadBuffers -> intel_draw_buffers. Second, that condition is no
longer tested for in our driver since ARB_ES2_compatibility was added.
Reviewed-by: Brian Paul <brianp at vmware.com>
---
src/mesa/drivers/dri/intel/intel_buffers.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_buffers.c b/src/mesa/drivers/dri/intel/intel_buffers.c
index a0fa091..7eb50ed 100644
--- a/src/mesa/drivers/dri/intel/intel_buffers.c
+++ b/src/mesa/drivers/dri/intel/intel_buffers.c
@@ -308,18 +308,6 @@ intelReadBuffer(struct gl_context * ctx, GLenum mode)
if (!was_front_buffer_reading && intel->is_front_buffer_reading)
dri2InvalidateDrawable(intel->driContext->driReadablePriv);
}
-
- if (ctx->ReadBuffer == ctx->DrawBuffer) {
- /* This will update FBO completeness status.
- * A framebuffer will be incomplete if the GL_READ_BUFFER setting
- * refers to a missing renderbuffer. Calling glReadBuffer can set
- * that straight and can make the drawing buffer complete.
- */
- intel_draw_buffer(ctx, ctx->DrawBuffer);
- }
- /* Generally, functions which read pixels (glReadPixels, glCopyPixels, etc)
- * reference ctx->ReadBuffer and do appropriate state checks.
- */
}
More information about the mesa-commit
mailing list