Mesa (master): swrast: Drop the global mapping of buffers across glReadPixels().

Eric Anholt anholt at kemper.freedesktop.org
Fri Nov 4 06:48:37 UTC 2011


Module: Mesa
Branch: master
Commit: d9f2add18102282a969a3662b3d89f32cece1074
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9f2add18102282a969a3662b3d89f32cece1074

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Oct 13 10:34:56 2011 -0700

swrast: Drop the global mapping of buffers across glReadPixels().

Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/swrast/s_readpix.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/mesa/swrast/s_readpix.c b/src/mesa/swrast/s_readpix.c
index f556213..c36746c 100644
--- a/src/mesa/swrast/s_readpix.c
+++ b/src/mesa/swrast/s_readpix.c
@@ -484,12 +484,6 @@ _swrast_ReadPixels( struct gl_context *ctx,
    if (ctx->NewState)
       _mesa_update_state(ctx);
 
-   /* Need to do swrast_render_start() before clipping or anything else
-    * since this is where a driver may grab the hw lock and get an updated
-    * window size.
-    */
-   swrast_render_start(ctx);
-
    /* Do all needed clipping here, so that we can forget about it later */
    if (_mesa_clip_readpixels(ctx, &x, &y, &width, &height, &clippedPacking)) {
 
@@ -518,6 +512,4 @@ _swrast_ReadPixels( struct gl_context *ctx,
          _mesa_unmap_pbo_dest(ctx, &clippedPacking);
       }
    }
-
-   swrast_render_finish(ctx);
 }




More information about the mesa-commit mailing list