Mesa (master): mesa: remove redundant buffer checks in copytexsubimage_error_check2()

Brian Paul brianp at kemper.freedesktop.org
Thu Oct 13 06:41:06 PDT 2011


Module: Mesa
Branch: master
Commit: 241b3e4bbe93ecab545b4454f656c9ffd073ae85
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=241b3e4bbe93ecab545b4454f656c9ffd073ae85

Author: Brian Paul <brianp at vmware.com>
Date:   Thu Oct 13 07:37:43 2011 -0600

mesa: remove redundant buffer checks in copytexsubimage_error_check2()

Again, there was already a call to _mesa_source_buffer_exists() earlier in
the function.

Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/main/teximage.c |   17 -----------------
 1 files changed, 0 insertions(+), 17 deletions(-)

diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 28c9705..84eed23 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -2133,23 +2133,6 @@ copytexsubimage_error_check2( struct gl_context *ctx, GLuint dimensions,
       return GL_TRUE;
    }
 
-   if (teximage->_BaseFormat == GL_DEPTH_COMPONENT) {
-      if (!ctx->ReadBuffer->_DepthBuffer) {
-         _mesa_error(ctx, GL_INVALID_OPERATION,
-                     "glCopyTexSubImage%dD(no depth buffer)",
-                     dimensions);
-         return GL_TRUE;
-      }
-   }
-   else if (teximage->_BaseFormat == GL_DEPTH_STENCIL_EXT) {
-      if (!ctx->ReadBuffer->_DepthBuffer || !ctx->ReadBuffer->_StencilBuffer) {
-         _mesa_error(ctx, GL_INVALID_OPERATION,
-                     "glCopyTexSubImage%dD(no depth/stencil buffer)",
-                     dimensions);
-         return GL_TRUE;
-      }
-   }
-
    /* If copying into an integer texture, the source buffer must also be
     * integer-valued.
     */



More information about the mesa-commit mailing list