Mesa (master): llvmpipe: compare front_facing to NULL to improve readability

Brian Paul brianp at kemper.freedesktop.org
Sun Oct 23 09:12:53 PDT 2011


Module: Mesa
Branch: master
Commit: c7aa8da9573f6d505bec894b4738f0521511b9f0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7aa8da9573f6d505bec894b4738f0521511b9f0

Author: Brian Paul <brianp at vmware.com>
Date:   Sun Oct 23 10:05:14 2011 -0600

llvmpipe: compare front_facing to NULL to improve readability

Compare 'front_facing' to NULL to make it more obvious that front_facing
is a pointer and not a simple boolean value.

---

 src/gallium/drivers/llvmpipe/lp_bld_depth.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_bld_depth.c b/src/gallium/drivers/llvmpipe/lp_bld_depth.c
index 5e0eb99..3e75e91 100644
--- a/src/gallium/drivers/llvmpipe/lp_bld_depth.c
+++ b/src/gallium/drivers/llvmpipe/lp_bld_depth.c
@@ -141,7 +141,7 @@ lp_build_stencil_test(struct lp_build_context *bld,
    res = lp_build_stencil_test_single(bld, &stencil[0],
                                       stencilRefs[0], stencilVals);
 
-   if (stencil[1].enabled && front_facing) {
+   if (stencil[1].enabled && front_facing != NULL) {
       /* do back face test */
       LLVMValueRef back_res;
 
@@ -253,7 +253,7 @@ lp_build_stencil_op(struct lp_build_context *bld,
    res = lp_build_stencil_op_single(bld, &stencil[0], op,
                                      stencilRefs[0], stencilVals);
 
-   if (stencil[1].enabled && front_facing) {
+   if (stencil[1].enabled && front_facing != NULL) {
       /* do back face op */
       LLVMValueRef back_res;
 



More information about the mesa-commit mailing list