Mesa (master): tgsi: Fix memory leak in out-of-memory path.
Vinson Lee
vlee at kemper.freedesktop.org
Tue Oct 25 18:13:18 UTC 2011
Module: Mesa
Branch: master
Commit: 265f55e6273aafc8e7607cd70a4b9756f7cb6bff
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=265f55e6273aafc8e7607cd70a4b9756f7cb6bff
Author: Vinson Lee <vlee at vmware.com>
Date: Tue Oct 25 08:23:02 2011 -0700
tgsi: Fix memory leak in out-of-memory path.
Fixes Coverity resource leak defect.
Reviewed-by: Brian Paul <brianp at vmware.com>
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 17 ++++++++++-------
1 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index b4eea54..1fb7f8f 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
@@ -674,16 +674,19 @@ tgsi_exec_machine_bind_shader(
if (mach->Processor == TGSI_PROCESSOR_GEOMETRY &&
!mach->UsedGeometryShader) {
- struct tgsi_exec_vector *inputs =
- align_malloc(sizeof(struct tgsi_exec_vector) *
- TGSI_MAX_PRIM_VERTICES * PIPE_MAX_ATTRIBS,
- 16);
- struct tgsi_exec_vector *outputs =
- align_malloc(sizeof(struct tgsi_exec_vector) *
- TGSI_MAX_TOTAL_VERTICES, 16);
+ struct tgsi_exec_vector *inputs;
+ struct tgsi_exec_vector *outputs;
+
+ inputs = align_malloc(sizeof(struct tgsi_exec_vector) *
+ TGSI_MAX_PRIM_VERTICES * PIPE_MAX_ATTRIBS,
+ 16);
if (!inputs)
return;
+
+ outputs = align_malloc(sizeof(struct tgsi_exec_vector) *
+ TGSI_MAX_TOTAL_VERTICES, 16);
+
if (!outputs) {
align_free(inputs);
return;
More information about the mesa-commit
mailing list