Mesa (master): svga: call u_default_redefine_user_buffer() to fix failed assertion

Brian Paul brianp at kemper.freedesktop.org
Wed Sep 21 22:33:25 UTC 2011


Module: Mesa
Branch: master
Commit: 559a0cd1fc3e8dab27075afa0064c1aebe003d9d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=559a0cd1fc3e8dab27075afa0064c1aebe003d9d

Author: Brian Paul <brianp at vmware.com>
Date:   Wed Sep 21 16:32:00 2011 -0600

svga: call u_default_redefine_user_buffer() to fix failed assertion

This fixes a regression from a8cf4b6acf9ee996090cc0bb95fa3558b481108c

The problem occured when two successive glDrawArrays calls accessed
subsequent elements in user-space arrays.  The user-space array
from the first call wasn't being grown to accomodate the second
draw call's elements.

Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>

---

 .../drivers/svga/svga_resource_buffer_upload.c     |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_resource_buffer_upload.c b/src/gallium/drivers/svga/svga_resource_buffer_upload.c
index a657a8b..36782d5 100644
--- a/src/gallium/drivers/svga/svga_resource_buffer_upload.c
+++ b/src/gallium/drivers/svga/svga_resource_buffer_upload.c
@@ -658,9 +658,6 @@ svga_redefine_user_buffer(struct pipe_context *pipe,
    assert(!sbuf->handle);
    assert(!sbuf->hwbuf);
 
-   /*
-    * We always treat the contents of user-buffers as volatile,
-    * so no particular action needed here.
-    */
-
+   /* use the default action of simply resizing the user buffer's size */
+   u_default_redefine_user_buffer(pipe, resource, offset, size);
 }




More information about the mesa-commit mailing list