Mesa (master): pipebuffer: split up assertion

Brian Paul brianp at kemper.freedesktop.org
Wed Apr 18 14:40:06 UTC 2012


Module: Mesa
Branch: master
Commit: 168a3b8627861fbb2786839f7e276de82f883e42
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=168a3b8627861fbb2786839f7e276de82f883e42

Author: Brian Paul <brianp at vmware.com>
Date:   Wed Apr 18 08:30:30 2012 -0600

pipebuffer: split up assertion

The problem with assert(a && b) is you don't know which term is zero
when there's a failure.

---

 src/gallium/auxiliary/pipebuffer/pb_bufmgr_debug.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/gallium/auxiliary/pipebuffer/pb_bufmgr_debug.c b/src/gallium/auxiliary/pipebuffer/pb_bufmgr_debug.c
index 2ea63d6..567303a 100644
--- a/src/gallium/auxiliary/pipebuffer/pb_bufmgr_debug.c
+++ b/src/gallium/auxiliary/pipebuffer/pb_bufmgr_debug.c
@@ -210,7 +210,8 @@ pb_debug_buffer_check(struct pb_debug_buffer *buf)
       if(underflow || overflow)
          debug_backtrace_dump(buf->create_backtrace, PB_DEBUG_CREATE_BACKTRACE);
 
-      debug_assert(!underflow && !overflow);
+      debug_assert(!underflow);
+      debug_assert(!overflow);
 
       /* re-fill if not aborted */
       if(underflow)




More information about the mesa-commit mailing list