Mesa (master): i965: Fix outdated comments about binding tables.

Kenneth Graunke kwg at kemper.freedesktop.org
Thu Apr 19 01:28:51 UTC 2012


Module: Mesa
Branch: master
Commit: 5177f6b1b99a68daf50e47dc420c0057fa5e8980
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5177f6b1b99a68daf50e47dc420c0057fa5e8980

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Wed Apr 18 18:21:24 2012 -0700

i965: Fix outdated comments about binding tables.

They had a number of issues:
- A paragraph states that we use a single binding table, but we don't.
- We labelled the WM binding table diagram as SOL/WM.
- The WM diagram had an "Only relevant to the WM" comment.  Duh.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/brw_context.h |   20 ++++++++------------
 1 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
index 0c50b6b..6df5b16 100644
--- a/src/mesa/drivers/dri/i965/brw_context.h
+++ b/src/mesa/drivers/dri/i965/brw_context.h
@@ -472,18 +472,14 @@ struct brw_vs_ouput_sizes {
  * For example, a shader might ask to sample from "surface 7."  In this case,
  * bind[7] would contain a pointer to a texture.
  *
- * Although the hardware supports separate binding tables per pipeline stage
- * (VS, HS, DS, GS, PS), we currently share a single binding table for all of
- * them.  This is purely for convenience.
- *
- * Currently our SOL/WM binding tables are (arbitrarily) programmed as follows:
+ * Currently, our WM binding tables are (arbitrarily) programmed as follows:
  *
  *    +-------------------------------+
- *    |   0 | Draw buffer 0           | .
- *    |   . |     .                   |  \
- *    |   : |     :                   |   > Only relevant to the WM.
- *    |   7 | Draw buffer 7           |  /
- *    |-----|-------------------------| `
+ *    |   0 | Draw buffer 0           |
+ *    |   . |     .                   |
+ *    |   : |     :                   |
+ *    |   7 | Draw buffer 7           |
+ *    |-----|-------------------------|
  *    |   8 | WM Pull Constant Buffer |
  *    |-----|-------------------------|
  *    |   9 | Texture 0               |
@@ -494,7 +490,7 @@ struct brw_vs_ouput_sizes {
  *
  * Our VS binding tables are programmed as follows:
  *
- *    +-----+-------------------------+ `
+ *    +-----+-------------------------+
  *    |   0 | VS Pull Constant Buffer |
  *    +-----+-------------------------+
  *    |   1 | Texture 0               |
@@ -506,7 +502,7 @@ struct brw_vs_ouput_sizes {
  * Our (gen6) GS binding tables are programmed as follows:
  *
  *    +-----+-------------------------+
- *    |  0  | SOL Binding 0           |
+ *    |   0 | SOL Binding 0           |
  *    |   . |     .                   |
  *    |   : |     :                   |
  *    |  63 | SOL Binding 63          |




More information about the mesa-commit mailing list