Mesa (master): egl: fix invalid flag detection for EGL_KHR_create_context

Matt Turner mattst88 at kemper.freedesktop.org
Mon Aug 27 22:10:25 UTC 2012


Module: Mesa
Branch: master
Commit: 971750e1cd76dabe22bf2ca83f07266837e3a2a6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=971750e1cd76dabe22bf2ca83f07266837e3a2a6

Author: Matt Turner <mattst88 at gmail.com>
Date:   Fri Aug 24 16:26:54 2012 -0700

egl: fix invalid flag detection for EGL_KHR_create_context

We want to check whether there are bits set outside of the valid flags.

Fixes piglit test egl-create-context-invalid-flag-gl

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/egl/main/eglcontext.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
index 829050d..71eca6f 100644
--- a/src/egl/main/eglcontext.c
+++ b/src/egl/main/eglcontext.c
@@ -341,7 +341,7 @@ _eglParseContextAttribList(_EGLContext *ctx, _EGLDisplay *dpy,
       break;
    }
 
-   if ((ctx->Flags & (EGL_CONTEXT_OPENGL_DEBUG_BIT_KHR
+   if ((ctx->Flags & ~(EGL_CONTEXT_OPENGL_DEBUG_BIT_KHR
                       | EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR
                       | EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR)) != 0) {
       err = EGL_BAD_ATTRIBUTE;




More information about the mesa-commit mailing list