Mesa (master): mesa: Add missing error check for first < 0 in glDrawArraysInstanced().

Kenneth Graunke kwg at kemper.freedesktop.org
Wed Feb 29 23:05:43 UTC 2012


Module: Mesa
Branch: master
Commit: 767ba60831657a684e3852c398a0d13d1201158f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=767ba60831657a684e3852c398a0d13d1201158f

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Feb 28 13:33:53 2012 -0800

mesa: Add missing error check for first < 0 in glDrawArraysInstanced().

Fixes piglit GL_ARB_draw_instanced/negative-arrays-first-negative.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/main/api_validate.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
index b10d8cd..4e94f47 100644
--- a/src/mesa/main/api_validate.c
+++ b/src/mesa/main/api_validate.c
@@ -383,6 +383,12 @@ _mesa_validate_DrawArraysInstanced(struct gl_context *ctx, GLenum mode, GLint fi
       return GL_FALSE;
    }
 
+   if (first < 0) {
+      _mesa_error(ctx, GL_INVALID_VALUE,
+		  "glDrawArraysInstanced(start=%d)", first);
+      return GL_FALSE;
+   }
+
    if (!_mesa_valid_prim_mode(ctx, mode)) {
       _mesa_error(ctx, GL_INVALID_ENUM,
                   "glDrawArraysInstanced(mode=0x%x)", mode);




More information about the mesa-commit mailing list