Mesa (master): i965: Disable PrimitiveID upload.

Kenneth Graunke kwg at kemper.freedesktop.org
Wed Feb 29 23:05:43 UTC 2012


Module: Mesa
Branch: master
Commit: c59bdee12ebc14fb97e33b8ef9df666422dafba5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c59bdee12ebc14fb97e33b8ef9df666422dafba5

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Feb 27 11:43:10 2012 -0800

i965: Disable PrimitiveID upload.

We currently don't support gl_PrimitiveID, and I believe asking the
hardware to generate it results in vertex cache invalidations.

This could result in slowdowns for applications that use gl_InstanceID,
which would be counter-productive.  Just turn it off for now.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>

---

 src/mesa/drivers/dri/i965/brw_draw_upload.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
index 331f2a0..11b9caa 100644
--- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
+++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
@@ -731,7 +731,7 @@ static void brw_emit_vertices(struct brw_context *brw)
 
       dw1 = ((BRW_VE1_COMPONENT_STORE_VID << BRW_VE1_COMPONENT_0_SHIFT) |
 	     (BRW_VE1_COMPONENT_STORE_IID << BRW_VE1_COMPONENT_1_SHIFT) |
-	     (BRW_VE1_COMPONENT_STORE_PID << BRW_VE1_COMPONENT_2_SHIFT) |
+	     (BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_2_SHIFT) |
 	     (BRW_VE1_COMPONENT_STORE_0 << BRW_VE1_COMPONENT_3_SHIFT));
 
       if (intel->gen >= 6) {




More information about the mesa-commit mailing list