Mesa (master): mesa: Fix bogus transform feedback error message when subscripting non-array.
Paul Berry
stereotype441 at kemper.freedesktop.org
Mon Jan 9 18:42:03 UTC 2012
Module: Mesa
Branch: master
Commit: 108cba21dec82a7e10962cf01f2835e7b950ff74
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=108cba21dec82a7e10962cf01f2835e7b950ff74
Author: Paul Berry <stereotype441 at gmail.com>
Date: Wed Jan 4 15:17:52 2012 -0800
mesa: Fix bogus transform feedback error message when subscripting non-array.
Previous to this patch, if the client requested transform feedback
using a subscript, but the variable was not an array
(e.g. "gl_FrontColor[0]"), we would produce a bogus error message like
"Transform feedback varying gl_FrontColor[0] found, but it's an array
([] expected)".
Changed the error message to e.g. "Transfrorm feedback varying
gl_FrontColor[0] requested, but gl_FrontColor is not an array."
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/glsl/linker.cpp | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 88c81c4..e8472d4 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -1576,9 +1576,9 @@ tfeedback_decl::assign_location(struct gl_context *ctx,
} else {
/* Regular variable (scalar, vector, or matrix) */
if (this->is_subscripted) {
- linker_error(prog, "Transform feedback varying %s found, "
- "but it's an array ([] expected).",
- this->orig_name);
+ linker_error(prog, "Transform feedback varying %s requested, "
+ "but %s is not an array.",
+ this->orig_name, this->var_name);
return false;
}
this->location = output_var->location;
More information about the mesa-commit
mailing list