Mesa (master): glcpp-test: don't return failure if valgrind tests aren' t run
Matt Turner
mattst88 at kemper.freedesktop.org
Tue Jan 31 02:10:45 UTC 2012
Module: Mesa
Branch: master
Commit: 82060adcde88eb57cc0a3b71d23f003f5637986f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=82060adcde88eb57cc0a3b71d23f003f5637986f
Author: Matt Turner <mattst88 at gmail.com>
Date: Sat Jan 28 22:08:39 2012 -0500
glcpp-test: don't return failure if valgrind tests aren't run
Success was (tests-passed AND valgrind-tests-passed) but this meant that
if the valgrind tests weren't run it would be considered a failure.
The logic is now (tests-passed AND (!valgrind OR valgrind-tests-passed))
which lets us return success if the valgrind tests aren't run.
Reviewed-by: Eric Anholt <eric at anholt.net>
Tested-by: Eric Anholt <eric at anholt.net>
Signed-off-by: Matt Turner <mattst88 at gmail.com>
---
src/glsl/glcpp/tests/glcpp-test | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/glsl/glcpp/tests/glcpp-test b/src/glsl/glcpp/tests/glcpp-test
index e8f3b54..1db7523 100755
--- a/src/glsl/glcpp/tests/glcpp-test
+++ b/src/glsl/glcpp/tests/glcpp-test
@@ -72,7 +72,7 @@ if [ "$do_valgrind" = "yes" ]; then
echo "$clean/$total tests are valgrind-clean"
fi
-if [ "$pass" = "$total" ] && [ "$clean" = "$total" ]; then
+if [ "$pass" = "$total" ] && [ "$do_valgrind" != "yes" ] || [ "$pass" = "$total" ]; then
exit 0
else
exit 1
More information about the mesa-commit
mailing list