Mesa (master): clover: Define non-templated copy constructor for clover:: ref_ptr.

Francisco Jerez currojerez at kemper.freedesktop.org
Sun Jul 1 13:55:43 UTC 2012


Module: Mesa
Branch: master
Commit: c6bb41c28b2da269d5b692d1d0f4acbf3cdd4b5c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c6bb41c28b2da269d5b692d1d0f4acbf3cdd4b5c

Author: Francisco Jerez <currojerez at riseup.net>
Date:   Thu Jun 28 01:16:23 2012 +0200

clover: Define non-templated copy constructor for clover::ref_ptr.

The templated copy constructor doesn't prevent the compiler from
emitting a default copy constructor, which leads to inconsistent
memory handling and was reported to cause segfaults when doing event
manipulation.

Reported-by: Tom Stellard <thomas.stellard at amd.com>

---

 src/gallium/state_trackers/clover/core/base.hpp |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/gallium/state_trackers/clover/core/base.hpp b/src/gallium/state_trackers/clover/core/base.hpp
index 19053f3..2a2e26a 100644
--- a/src/gallium/state_trackers/clover/core/base.hpp
+++ b/src/gallium/state_trackers/clover/core/base.hpp
@@ -88,8 +88,7 @@ namespace clover {
          reset(q);
       }
 
-      template<typename S>
-      ref_ptr(const ref_ptr<S> &ref) : p(NULL) {
+      ref_ptr(const ref_ptr<T> &ref) : p(NULL) {
          reset(ref.p);
       }
 




More information about the mesa-commit mailing list