Mesa (master): radeon/llvm: Don' t set the IMM bit in SMRD instruction definitions.

Tom Stellard tstellar at kemper.freedesktop.org
Wed Jul 11 18:45:59 UTC 2012


Module: Mesa
Branch: master
Commit: bbdf3af8577ca61fc54c4a1615e80940c904636e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bbdf3af8577ca61fc54c4a1615e80940c904636e

Author: Tom Stellard <thomas.stellard at amd.com>
Date:   Tue Jul 10 08:51:31 2012 -0400

radeon/llvm: Don't set the IMM bit in SMRD instruction definitions.

The IMM bit is already being set in SICodeEmitter.

---

 src/gallium/drivers/radeon/SIInstrInfo.td |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/gallium/drivers/radeon/SIInstrInfo.td b/src/gallium/drivers/radeon/SIInstrInfo.td
index 30c9c33..be08e8a 100644
--- a/src/gallium/drivers/radeon/SIInstrInfo.td
+++ b/src/gallium/drivers/radeon/SIInstrInfo.td
@@ -448,7 +448,6 @@ class MTBUF_Store_Helper <bits<3> op, string asm, RegisterClass regClass> : MTBU
   let mayStore = 1;
 }
 
-/*XXX: We should be able to infer the imm bit based on the arg types */
 multiclass SMRD_Helper <bits<5> op, string asm, RegisterClass dstClass,
 			ValueType vt> {
 
@@ -458,9 +457,7 @@ multiclass SMRD_Helper <bits<5> op, string asm, RegisterClass dstClass,
               (ins SMRDmemrr:$src0),
               asm,
               [(set (vt dstClass:$dst), (constant_load ADDR_Reg:$src0))]
-  > {
-    let IMM = 0;
-  }
+  >;
 
   def _IMM : SMRD <
               op,
@@ -468,9 +465,7 @@ multiclass SMRD_Helper <bits<5> op, string asm, RegisterClass dstClass,
               (ins SMRDmemri:$src0),
               asm,
               [(set (vt dstClass:$dst), (constant_load ADDR_Offset8:$src0))]
-  > {
-    let IMM = 1;
-  }
+  >;
 }
 
 include "SIInstrFormats.td"




More information about the mesa-commit mailing list