Mesa (master): egl_dri2: NULL check for EGLNativeWindowType

Brian Paul brianp at kemper.freedesktop.org
Mon Jul 16 22:12:51 UTC 2012


Module: Mesa
Branch: master
Commit: cf775c9cbf86676aa321eb9665fe38aeba35afc9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf775c9cbf86676aa321eb9665fe38aeba35afc9

Author: Elvis Lee <kwangwoong.lee at lge.com>
Date:   Wed Jul 11 11:13:51 2012 +0900

egl_dri2: NULL check for EGLNativeWindowType

Some application calls eglCreateWindowSurface with
EGLNativeWindowType parameter having zero value. It causes SEGV
and disturbs error handling like EGL_NO_SURFACE.

Signed-off-by: Elvis Lee <kwangwoong.lee at lge.com>
Signed-off-by: Brian Paul <brianp at vmware.com>

---

 src/egl/drivers/dri2/platform_drm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c
index 54067ff..9aafb52 100644
--- a/src/egl/drivers/dri2/platform_drm.c
+++ b/src/egl/drivers/dri2/platform_drm.c
@@ -108,6 +108,8 @@ dri2_create_surface(_EGLDriver *drv, _EGLDisplay *disp, EGLint type,
 
    switch (type) {
    case EGL_WINDOW_BIT:
+      if (!window)
+         return NULL;
       surf = gbm_dri_surface((struct gbm_surface *) window);
       dri2_surf->gbm_surf = surf;
       dri2_surf->base.Width =  surf->base.width;




More information about the mesa-commit mailing list